Add dev.yml (for Shopify employees) #865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyw8
commented
May 25, 2021
| @@ -0,0 +1,11 @@ | |||
| name: shopify-api | |||
There was a problem hiding this comment.
dev doesn't allow underscore in project names.
There was a problem hiding this comment.
Would it make sense to make the name a little bit more descriptive here, like shopify-ruby-api?
There was a problem hiding this comment.
From what I've seen elsewhere, the name typically matches the repo name. I don't think it matters too much.
paulomarg
approved these changes
May 26, 2021
| @@ -0,0 +1,11 @@ | |||
| name: shopify-api | |||
There was a problem hiding this comment.
Would it make sense to make the name a little bit more descriptive here, like shopify-ruby-api?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a basic configuration for
dev, the tooling used internally at Shopify.