Resolve Policial errors

Shopify · Aug 23, 2018 · 58e7c56 · 58e7c56
1 parent 83eed27
commit 58e7c56
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/lib/shopify_app/controller_concerns/login_protection.rb b/lib/shopify_app/controller_concerns/login_protection.rb
@@ -62,7 +62,11 @@ def login_url(top_level: false)
 
       query_params = {}
       query_params[:shop] = sanitized_params[:shop] if params[:shop].present?
-      query_params[:shop] ||= referer_sanitized_shop_name if referer_sanitized_shop_name.present?
+
+      if referer_sanitized_shop_name.present?
+        query_params[:shop] ||= referer_sanitized_shop_name
+      end
+
       query_params[:top_level] = true if top_level
 
       url = "#{url}?#{query_params.to_query}" if query_params.present?

diff --git a/lib/shopify_app/engine.rb b/lib/shopify_app/engine.rb
@@ -4,7 +4,8 @@ class Engine < Rails::Engine
     isolate_namespace ShopifyApp
 
     initializer "shopify_app.assets.precompile" do |app|
-      app.config.assets.precompile += %w( shopify_app/redirect.js shopify_app/itp_polyfill.js )
+      app.config.assets.precompile += %w[ shopify_app/redirect.js 
+      shopify_app/itp_polyfill.js ]
     end
   end
 end