Redirect EnsureAuthenticatedLinks to login page if current_shopify_do…

…main not found
Shopify · Jan 22, 2021 · 6c5a46e · 6c5a46e
1 parent c9e2257
commit 6c5a46e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/app/controllers/concerns/shopify_app/ensure_authenticated_links.rb b/app/controllers/concerns/shopify_app/ensure_authenticated_links.rb
@@ -13,6 +13,8 @@ module EnsureAuthenticatedLinks
     def redirect_to_splash_page
       splash_page_path = root_path(return_to: request.fullpath, shop: current_shopify_domain)
       redirect_to(splash_page_path)
+    rescue ShopifyApp::LoginProtection::ShopifyDomainNotFound
+      redirect_to(ShopifyApp.configuration.login_url)
     end
 
     def missing_expected_jwt?

diff --git a/test/controllers/concerns/ensure_authenticated_links_test.rb b/test/controllers/concerns/ensure_authenticated_links_test.rb
@@ -55,4 +55,12 @@ def current_shopify_domain
 
     assert_response :ok
   end
+
+  test 'redirects to login page if current shopify domain is not found' do
+    @controller.expects(:current_shopify_domain).raises(ShopifyApp::LoginProtection::ShopifyDomainNotFound)
+
+    get :some_link
+
+    assert_redirected_to ShopifyApp.configuration.login_url
+  end
 end