Renaming var flash to flashData

Shopify · May 8, 2019 · a246d8a · a246d8a
1 parent 32af7ac
commit a246d8a
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/example/app/assets/javascripts/flash_messages.js b/example/app/assets/javascripts/flash_messages.js
@@ -2,14 +2,14 @@ var eventName = typeof(Turbolinks) !== 'undefined' ? 'turbolinks:load' : 'DOMCon
 
 if (!document.documentElement.hasAttribute("data-turbolinks-preview")) {
   document.addEventListener(eventName, function flash() {
-    var flash = JSON.parse(document.getElementById('shopify-app-flash').dataset.flash);
+    var flashData = JSON.parse(document.getElementById('shopify-app-flash').dataset.flash);
 
-    if (flash.notice) {
-      ShopifyApp.flashNotice(flash.notice);
+    if (flashData.notice) {
+      ShopifyApp.flashNotice(flashData.notice);
     }
 
-    if (flash.error) {
-      ShopifyApp.flashError(flash.error);
+    if (flashData.error) {
+      ShopifyApp.flashError(flashData.error);
     }
 
     document.removeEventListener(eventName, flash)

diff --git a/lib/generators/shopify_app/install/templates/flash_messages.js b/lib/generators/shopify_app/install/templates/flash_messages.js
@@ -2,14 +2,14 @@ var eventName = typeof(Turbolinks) !== 'undefined' ? 'turbolinks:load' : 'DOMCon
 
 if (!document.documentElement.hasAttribute("data-turbolinks-preview")) {
   document.addEventListener(eventName, function flash() {
-    var flash = JSON.parse(document.getElementById('shopify-app-flash').dataset.flash);
+    var flashData = JSON.parse(document.getElementById('shopify-app-flash').dataset.flash);
 
-    if (flash.notice) {
-      ShopifyApp.flashNotice(flash.notice);
+    if (flashData.notice) {
+      ShopifyApp.flashNotice(flashData.notice);
     }
 
-    if (flash.error) {
-      ShopifyApp.flashError(flash.error);
+    if (flashData.error) {
+      ShopifyApp.flashError(flashData.error);
     }
 
     document.removeEventListener(eventName, flash)