Skip to content

Commit

Permalink
bump dependency to latest major version of the API (#1801)
Browse files Browse the repository at this point in the history
* bump dependency to latest major version of the API

* drop ruby 2.7 from CI

* increase mimimum ruby to 3.0

* allow API gem to be released to major/minor versions without requiring dependency changes here

* allow patches and minor releases of api without requiring releasing this gem

* update rubocop ruby version

* ruby 3.2 for rubocop

* breaking changelog

* reorder breaking chang
  • Loading branch information
nelsonwittwer committed Mar 5, 2024
1 parent 2a75c07 commit f5aaf8c
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
name: Ruby ${{ matrix.version }}
strategy:
matrix:
version: ['2.7', '3.0', '3.1', '3.2']
version: ['3.0', '3.1', '3.2']

steps:
- uses: actions/checkout@v3
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ jobs:

steps:
- uses: actions/checkout@v3
- name: Set up Ruby 2.7
- name: Set up Ruby 3.2
uses: ruby/setup-ruby@v1
with:
ruby-version: 2.7
ruby-version: 3.2
bundler-cache: true
- name: Install gems
run: |
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
Unreleased
----------
* ⚠️ [Breaking] Bumps minimum supported Ruby version to 3.0. Bumps `shopify_api` to 14.0 [1801](https://github.com/Shopify/shopify_app/pull/1801)
* Make type param for webhooks route optional. This will fix a bug with CLI initiated webhooks.[1786](https://github.com/Shopify/shopify_app/pull/1786)
* Fix redirecting to login when we catch a 401 response from Shopify, so that it can also handle cases where the app is already embedded when that happens.[1787](https://github.com/Shopify/shopify_app/pull/1787)
* Always register webhooks with offline sessions.[1788](https://github.com/Shopify/shopify_app/pull/1788)
Expand Down
4 changes: 2 additions & 2 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ PATH
jwt (>= 2.2.3)
rails (> 5.2.1)
redirect_safely (~> 1.0)
shopify_api (~> 13.4)
shopify_api (~> 14)
sprockets-rails (>= 2.0.0)

GEM
Expand Down Expand Up @@ -217,7 +217,7 @@ GEM
ruby-progressbar (1.13.0)
ruby2_keywords (0.0.5)
securerandom (0.2.2)
shopify_api (13.4.0)
shopify_api (14.0.0)
activesupport
concurrent-ruby
hash_diff
Expand Down
4 changes: 2 additions & 2 deletions shopify_app.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ Gem::Specification.new do |s|
s.author = "Shopify"
s.summary = "This gem is used to get quickly started with the Shopify API"

s.required_ruby_version = ">= 2.7"
s.required_ruby_version = ">= 3.0"

s.metadata["allowed_push_host"] = "https://rubygems.org"

Expand All @@ -20,7 +20,7 @@ Gem::Specification.new do |s|
s.add_runtime_dependency("jwt", ">= 2.2.3")
s.add_runtime_dependency("rails", "> 5.2.1")
s.add_runtime_dependency("redirect_safely", "~> 1.0")
s.add_runtime_dependency("shopify_api", "~> 13.4")
s.add_runtime_dependency("shopify_api", "~> 14")
s.add_runtime_dependency("sprockets-rails", ">= 2.0.0")

s.add_development_dependency("byebug")
Expand Down

0 comments on commit f5aaf8c

Please sign in to comment.