Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clickjacking and CSP policy preventing approval #1428

Closed
resistorsoftware opened this issue May 9, 2022 · 2 comments
Closed

Clickjacking and CSP policy preventing approval #1428

resistorsoftware opened this issue May 9, 2022 · 2 comments
Assignees
Labels

Comments

@resistorsoftware
Copy link

resistorsoftware commented May 9, 2022

100% of what I check shows the CSP Policy in place and rendering the right data.

100% of Shopify robot rejects App due to clickjacking and CSP policy.

GET IT TOGETHER SHOPIFY and help us use this App to make Apps that pass the stupid robot test. What are we supposed to be doing here to pass this stupid test?

When I inspect the shop in my browser, the CSP is

Content-Security-Policy frame-ancestors https://mytestapp.myshopify.com https://admin.shopify.com;

When I send a bogus webhook to the App, I also see that. Seems right to me as it matches the documentation. But the robot hates it. WHY????

@resistorsoftware resistorsoftware changed the title WTF Shopify - This App is borked so bad This App is borked so bad May 10, 2022
@resistorsoftware
Copy link
Author

The reason I mention Webhooks is that when you decorate the CSP code in this App, you might have a params[:shop], or you might not. So is the CSP based on that? Webhooks controller is not the same as Authenticated controller, and yet the App review robot needs both CSP results to be the same? How does that work?

@nelsonwittwer nelsonwittwer changed the title This App is borked so bad Clickjacking and CSP policy preventing approval Aug 23, 2022
@nelsonwittwer nelsonwittwer self-assigned this Aug 24, 2022
@nelsonwittwer
Copy link
Contributor

#1474 should address the concerns pointed out here, so we are going to close this issue.

If you still encounter this issue with the latest stable version, please reopen using the issue template. You can also contribute directly by submitting a pull request– see the CONTRIBUTING.md(.github/CONTRIBUTING.md) file for guidelines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants