Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fullpage redirect not working #1637

Closed
vmatiyko opened this issue Jan 6, 2023 · 5 comments
Closed

Fullpage redirect not working #1637

vmatiyko opened this issue Jan 6, 2023 · 5 comments

Comments

@vmatiyko
Copy link

vmatiyko commented Jan 6, 2023

Some users encountered the fullpage redirect issue when making an application subscription. In this case, the browser does not matter, the fullpage redirect does not occur for specific users, but for some users, it works properly. This is what the page looks like when a user has an issue:

Screenshot 2023-01-06 at 18 33 55

  • shopify_api version: 9.5.1
  • shopify_app version: 18.1.2
  • App Bridge version: 2.0.5
  • Ruby version: 2.6.10

Similar issue: #1387
Also, we have the host in the URL and receive it in params.

Any help would be appreciated.

@vasaf
Copy link

vasaf commented Jan 13, 2023

Having some trouble with this too. full_page_redirect breaks if the store is using the new admin.shopify.com domain.

If I force set the host to admin.shopify.com/store/storename the redirect works.. Have you checked to see what host is being set using Base64.urlsafe_decode64?

If it's relevant; Anecdotally, when creating a new recurring charge, the returned confirmation url is still using storename.myshopify.com when the url should instead be admin.shopify.com

@khoimm92
Copy link

khoimm92 commented Feb 4, 2023

This works for me:
params["host"] = Base64.urlsafe_encode64("admin.shopify.com/store/#{current_shopify_domain}", padding: false) fullpage_redirect_to @recurring_application_charge.confirmation_url.to_s + '&host=' + params["host"] response.status = 303

@vmatiyko
Copy link
Author

@vasaf @khoimm92 Thank you 🙏

@nelsonwittwer
Copy link
Contributor

This will be fixed with #1658 - the new admin url structure is getting tested. thank you @khoimm92 for the handy workaround

@jackculpan
Copy link

This works for me: params["host"] = Base64.urlsafe_encode64("admin.shopify.com/store/#{current_shopify_domain}", padding: false) fullpage_redirect_to @recurring_application_charge.confirmation_url.to_s + '&host=' + params["host"] response.status = 303

Thanks for this - was really hoping it would solve it for me but still no redirect to the confirmation url

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants