Support Unified Admin #1658
Merged
Support Unified Admin #1658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wasn't able to get this to work with spin domains yet. Working on the spin fix now, but I imagine it will be a very similar approach. Or we can ship this now and work on a spin fix later. |
nelsonwittwer
approved these changes
Mar 6, 2023
klenotiw
force-pushed
the
klenotiw/add-unified-admin
branch
from
d5c67f8
to
a462388
Compare
This was referenced Mar 21, 2023
klenotiw
force-pushed
the
klenotiw/add-unified-admin
branch
from
32a62b6
to
03882c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Installs with the unified admin url were not working. This PR recognizes if a unified admin url was used and converts it to the old url format. This is a bandaid right now since core doesn't support the authorize routes with the new format.
closes #1660
Reviewer's guide to testing
Try to install an app using a unified admin store url.
Things to focus on
unified_admin?(uri)a good way to determine if a url is unified admin?Checklist
Before submitting the PR, please consider if any of the following are needed:
CHANGELOG.mdif the changes would impact usersREADME.md, if appropriate./docs, if necessary