-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update HTML files to use new design language styles #1102
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎩 ed, and from the code / app perspective it seems good to me!
In any case, I'm re-adding the team review if someone wants to take a closer look at the style itself, but as far as I can tell the app itself is working just fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im not sure how much of this is just auto generated and pulled in; or what you've written yourself. Just left a few comments. Looks good otherwise!
…design_language_update
Closes #1099
This PR updates all styles and HTML used in the
html.erb
files to adhere to the new design language that has shipped across the store admin.Design Language Figma for reference.
Tophatting
shopify_app
gem.bundle exec rails server
) to view the install app page (new.html.erb
). This page was not totally following Polaris styles before so I have updated the HTML and styles to better follow Polaris guidelines.top_level_interaction.html.erb
page.Continue
and you will see therequest_storage_access.html.erb
page.12.0.0
to see theenable_cookies.html.erb
page. You can do this by clicking onDevelop > User Agent > Other
![Screen Shot 2020-11-05 at 11 18 59 AM](https://user-images.githubusercontent.com/28414220/98266985-e38a3200-1f58-11eb-8a6f-c717787de775.png)
And then changing the version to `12.0.0`![Screen Shot 2020-11-05 at 11 19 17 AM](https://user-images.githubusercontent.com/28414220/98267037-eedd5d80-1f58-11eb-8dc2-4c9859efcf92.png)
This should now show you the correct page: