Ensure offline and online tokens are fetched via available auth hash #1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rezaansyed
force-pushed
the
fix-failing-post-perform-jobs
branch
from
6c2f28b
to
0707d5f
Compare
rezaansyed
requested review from
ragalie,
greatestape,
alexaitken and
theundeadmonk
|
Thanks for this. Took care of the problem nicely. |
rezaansyed
force-pushed
the
fix-failing-post-perform-jobs
branch
from
0707d5f
to
4cc2614
Compare
rezaansyed
force-pushed
the
fix-failing-post-perform-jobs
branch
from
4cc2614
to
d779e0a
Compare
greatestape
reviewed
Jan 19, 2021
4 tasks
macdonaldr93
pushed a commit
to obsidian-apps/shopify_app
that referenced
this pull request
Mar 26, 2021
…-jobs Ensure offline and online tokens are fetched via available auth hash
macdonaldr93
added a commit
to obsidian-apps/shopify_app
that referenced
this pull request
Mar 26, 2021
…-jobs (#1) Ensure offline and online tokens are fetched via available auth hash Co-authored-by: rezaansyed <60748788+rezaansyed@users.noreply.github.com>
macdonaldr93
pushed a commit
to obsidian-apps/shopify_app
that referenced
this pull request
Mar 26, 2021
…-jobs Ensure offline and online tokens are fetched via available auth hash
macdonaldr93
pushed a commit
to obsidian-apps/shopify_app
that referenced
this pull request
Mar 26, 2021
…-jobs Ensure offline and online tokens are fetched via available auth hash
This was referenced Mar 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1128
We have noticed that the callback controller was fetching a token based on the session object for post perform jobs. This is not necessary as the offline and/or online tokens can be retrieved via the auth hash.
Before submitting the PR, please consider if any of the following are needed:
CHANGELOG.mdif the changes would impact usersREADME.md, if appropriate.docs/, if necessary