Fetch access scope via #dig in callback controller

[kirillplatonov]

Problem

After upgrading to v17.1.0 I noticed that controller tests are not passing. I use OmniAuth mock in controller tests to login as shop:

class ActionDispatch::IntegrationTest
  def login(shop)
    OmniAuth.config.test_mode = true
    OmniAuth.config.add_mock(:shopify,
      provider: 'shopify',
      uid: shop.shopify_domain,
      credentials: { token: shop.shopify_token })
    Rails.application.env_config["omniauth.auth"] = OmniAuth.config.mock_auth[:shopify]

    get "/auth/shopify"
    follow_redirect!
  end
end

This code started raising an error:

What this PR does

Changes the syntax for fetching access_scope in CallbackController to be tolerant to empty auth_hash['extra'].
Hash#dig is supported since Ruby 2.3 so it shouldn't break anything (since the library requires ruby >= 2.5).

[NabeelAhsen]

Thank you for this! Can confirm this results in an error currently for Omniauth mocks

(Also can confirm that this change fixes the resulting errors)

[rezaansyed]

@kirillplatonov you'll need to sign the CLA in order to contribute to the gem.

[kirillplatonov]

@rezaansyed Already signed CLA but the check not updated. Do I need to do anything else?

[NabeelAhsen]

@rezaansyed Already signed CLA but the check not updated. Do I need to do anything else?

🤔 Hmm, try pushing up an empty commit to re-trigger the CLI?

[kirillplatonov]

Done. CLA check is green now.

[rezaansyed]

@kirillplatonov we pushed a fix so that the builds can run. Could you rebase your fork and push that up again?

[kirillplatonov]

@rezaansyed Done. All green now.

[rezaansyed]

@kirillplatonov thanks again for the fix! We've shipped this to the latest 17.1.1 version