Fetch host from query or HTTP header "shopify-app-bridge-host" for AppBridge V2 #1403
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Currently, AppBridge 2.0 needs a
host
parameter to initialize and work. But after migrating to session token, we can't easily get thehost
in each query. So, as inspired from #1360, we can use HTTP header to manual pass the host back to server instead of manually putting them in URL or cache in cookies.Reviewer's guide to testing
Go check the additional concern
ShopifyApp::SetShopHost
which fetching host fromparams[:host]
or the HTTP headershopify-app-bridge-host
. This will help a Rails app to keep holding thehost
on hand through settinghost
in HTTP header by turbolinks or turbo and sending it back in view.Checklist
Before submitting the PR, please consider if any of the following are needed:
CHANGELOG.md
if the changes would impact usersREADME.md
, if appropriate./docs
, if necessary