Allow custom OAuth URLs #1445
Merged
Allow custom OAuth URLs #1445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonzaloriestra
approved these changes
Jun 10, 2022
paulomarg
force-pushed
the
allow_custom_oauth_routes
branch
3 times, most recently
from
f6a1855
to
893478f
Compare
paulomarg
force-pushed
the
allow_custom_oauth_routes
branch
from
893478f
to
abfd049
Compare
paulomarg
force-pushed
the
allow_custom_oauth_routes
branch
from
abfd049
to
68d9cb6
Compare
hannachen
approved these changes
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
In some cases, the Shopify routes might be mounted under a custom
root_url, when theEngineis not mounted at/. Assuming thatroot_urlis expected to match the root URL for theEngine, this PR adds support for customizing both the OAuth login and callback routes so that they can be arbitrarily determined by the app.The goal here is for this to preserve the current behaviour by default, so I just wanted to make sure that assumption about
root_urlis actually correct.Reviewer's guide to testing
Tested via unit tests and by using the gem locally on a CLI-generated app.
Things to focus on
root_urlfrom the URLs when setting up the routes? That is where the assumption aboutroot_urlcomes into play.Checklist
Before submitting the PR, please consider if any of the following are needed:
CHANGELOG.mdif the changes would impact users