Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore extra kwargs on perform() in WebhooksManagerJob #1467

Closed
wants to merge 2 commits into from
Closed

Ignore extra kwargs on perform() in WebhooksManagerJob #1467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f87a273
Ignore extra kwargs on `perform()` in WebhooksManagerJob
minichate Jul 6, 2022
07aa45e
Update CHANGELOG
minichate Jul 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
Unreleased
----------

19.1.1 (July 6, 2022)
----------

* Accept extra keyword arguments to WebhooksManagerJob to ease upgrade path from v18 or older (https://github.com/Shopify/shopify_app/pull/1466)

19.1.0 (June 20, 2022)
----------

Expand Down
2 changes: 1 addition & 1 deletion lib/shopify_app/jobs/webhooks_manager_job.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ class WebhooksManagerJob < ActiveJob::Base
ShopifyApp.configuration.webhooks_manager_queue_name
end

def perform(shop_domain:, shop_token:)
def perform(shop_domain:, shop_token:, **)
ShopifyAPI::Auth::Session.temp(shop: shop_domain, access_token: shop_token) do |session|
WebhooksManager.create_webhooks(session: session)
end
Expand Down