Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix method signature of super #1513

Merged
merged 3 commits into from
Sep 20, 2022
Merged

fix method signature of super #1513

merged 3 commits into from
Sep 20, 2022

Conversation

nelsonwittwer
Copy link
Contributor

What this PR does

Fixes the method signature of StandardError when we call super

Reviewer's guide to testing

In a Rails app that uses this branch of the gem (gem "shopify_app, git: "git@github.com:Shopify/shopify_app.git", "branch: nelsonwittwer/billing_error") ensure that you can instantiate a BillingError

🎩

irb(main):001:0> ShopifyApp::EnsureBilling::BillingError.new("Error while billing the store", [{"field"=>nil, "message"=>"message"}])
=> #<ShopifyApp::EnsureBilling::BillingError: Error while billing the store>

I was able to do instatiate an error without it complaining as reported in this issue

Checklist

Before submitting the PR, please consider if any of the following are needed:

  • Update CHANGELOG.md if the changes would impact users
  • Update README.md, if appropriate.
  • Update any relevant pages in /docs, if necessary
  • For security fixes, the Disclosure Policy must be followed.

klenotiw
klenotiw approved these changes Sep 20, 2022
View reviewed changes
Copy link
Contributor

@klenotiw klenotiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nelsonwittwer nelsonwittwer merged commit 01bf686 into main Sep 20, 2022
@nelsonwittwer nelsonwittwer deleted the nelsonwittwer/billing_error branch September 20, 2022 14:48
@nelsonwittwer nelsonwittwer mentioned this pull request Sep 20, 2022
Closed
klenotiw added a commit that referenced this pull request Sep 27, 2022
@klenotiw
match recent pr to fix method sig #1513
a1c0ce6
fabriazza pushed a commit to fabriazza/shopify_app that referenced this pull request Feb 1, 2023
@nelsonwittwer @fabriazza
fix method signature of super (Shopify#1513)
f5461d1 
* fix method signature of super

* typo for userErrors

* Changelog
fabriazza pushed a commit to fabriazza/shopify_app that referenced this pull request Feb 1, 2023
@klenotiw @fabriazza
match recent pr to fix method sig Shopify#1513
836fa9e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klenotiw klenotiw klenotiw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nelsonwittwer @klenotiw