Move ownership for session persistence from library to this gem #1563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
nelsonwittwer
force-pushed
the
nelsonwittwer/api_session
branch
from
427faab
to
bd65c2d
Compare
nelsonwittwer
changed the title
klenotiw
approved these changes
Dec 7, 2022
|
Thanks for the 🎩 , @klenotiw ! Before we release the next version, I'll do a test with the CLI to make sure everything looks good as well! |
fabriazza
pushed a commit
to fabriazza/shopify_app
that referenced
this pull request
Feb 1, 2023
…ify#1563) * session stored in rails instead of library * move responsiblity for session persistence * move load_current_session to login_protection * FIXME notes * Move session concerns back to session utils * Add `embedded` param to `splash_page` (Shopify#1549) * use online tokens appropriately if there is a user session storage available * move load_current_session to login_protection * Move session concerns back to session utils * refactor login protection and tests with sesison ownership change * rubocop'd * no more session_storage in generated example * add x86_65-linux platform for CI * no more local pointer to api lib * more gemlock Co-authored-by: rdillensnyder <101280580+rdillensnyder@users.noreply.github.com> Co-authored-by: Teddy Hwang <teddy.hwang@shopify.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Exploring the idea of moving session persistence calls to this gem instead of passing
ShopifyApp::SessionRepositoryto the API library and having the API library be responsible for persisting the session. Having the API library invoke Rails' persistence is backward from a responsibility perspective.The goal with this proposal is to use the API library that already returns a session payload to the
shopify_appand use that payload to persist and load session data using theShopifyApp::SessionRepositoryexclusively and remove any concept of session persistence from the API library.TODO
ShopifyAPI::Auth::SessionStoragefromSessionRepositorynow?Reviewer's guide to testing
This is a risky change in that all API calls and authentication code has been modified. We'll want to perform a full regression of the features of the gem and ensure we can make rest / graphql calls with the new session interface.
Checklist
Before submitting the PR, please consider if any of the following are needed:
CHANGELOG.mdif the changes would impact usersREADME.md, if appropriate./docs, if necessary