use online tokens when available #1566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teddyhwang
commented
Nov 3, 2022
| def online_token_configured? | ||
| !ShopifyApp.configuration.user_session_repository.blank? && ShopifyApp::SessionRepository.user_storage.present? | ||
| end | ||
|
|
||
| def user_session_expected? | ||
| return false if shop_session.nil? |
There was a problem hiding this comment.
shop_session here would only be available during OAuth since it does a shop look up by the shop parameter which is only sent during the beginning of OAuth. this would always return false since subsequent proxy API requests would not have the shop query parameter required to do this look up
teddyhwang
commented
Nov 3, 2022
nelsonwittwer
approved these changes
Nov 4, 2022
andyw8
approved these changes
Nov 4, 2022
teddyhwang
force-pushed
the
fix-offline-tokens
branch
from
27bff07
to
e63846f
Compare
teddyhwang
force-pushed
the
fix-offline-tokens
branch
from
e63846f
to
0da8947
Compare
teddyhwang
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Related to https://github.com/Shopify/shopify-graphiql-app/issues/1069
There is currently logic on when to retrieve an online or offline session token where
current_shopify_sessionin theLoginProtectionconcern makes an incorrect assumption on checking if a shop session exists when determining to pass inis_onlineto load the session from the API gem. This check is required for the original OAuth request but any subsequent requests after OAuth should just check if a User session is configured.Reviewer's guide to testing
Checklist
Before submitting the PR, please consider if any of the following are needed:
CHANGELOG.mdif the changes would impact usersREADME.md, if appropriate./docs, if necessary