Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AppBridge to 3.7.8 #1680

Merged
merged 11 commits into from
Jul 26, 2023
Merged

Conversation

kirillplatonov
Copy link
Contributor

@kirillplatonov kirillplatonov commented Apr 5, 2023

What this PR does

Updates AppBridge to the latest version. This is mandatory to comply with Built for Shopify program requirements. Source code of AppBridge copied from https://unpkg.com/@shopify/app-bridge@3.7.7/umd/index.js

Checklist

Before submitting the PR, please consider if any of the following are needed:

  • Update CHANGELOG.md if the changes would impact users
  • Update README.md, if appropriate.
  • Update any relevant pages in /docs, if necessary
  • For security fixes, the Disclosure Policy must be followed.

@kirillplatonov kirillplatonov force-pushed the update-app-bridge branch 3 times, most recently from 0f774cf to 482c39e Compare April 5, 2023 09:34
@kirillplatonov
Copy link
Contributor Author

@nelsonwittwer @mkevinosullivan could you please review it?

@kirillplatonov kirillplatonov changed the title Update AppBridge to 3.7.5 Update AppBridge to 3.7.7 May 18, 2023
@kirillplatonov kirillplatonov mentioned this pull request May 18, 2023
4 tasks
@kirillplatonov
Copy link
Contributor Author

Bumped to AppBridge 3.7.7. Ready to be merged 🙂

cc @nelsonwittwer @mkevinosullivan @hannachen

@kirillplatonov
Copy link
Contributor Author

cc @paulomarg

@BranLiang
Copy link
Contributor

@kirillplatonov Actually, 3.7.8 is also released, do you consider bumping to the latest?

@kirillplatonov
Copy link
Contributor Author

@BranLiang sure, I will update it now

@kirillplatonov kirillplatonov changed the title Update AppBridge to 3.7.7 Update AppBridge to 3.7.8 Jul 24, 2023
@kirillplatonov
Copy link
Contributor Author

@BranLiang bumped to 3.7.8. Could you please take a look at #1635? This PR includes pretty important bugfix but we couldn't get it merged for a while.

@nelsonwittwer
Copy link
Contributor

Thanks again for your patience on this and your contribution! I verified this change by using this branch in a test app. Everything seemed to work as expected

@nelsonwittwer nelsonwittwer merged commit ae86726 into Shopify:main Jul 26, 2023
7 checks passed
@kirillplatonov kirillplatonov deleted the update-app-bridge branch October 11, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants