Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in customers/redact webhook topic #1704

Merged
merged 5 commits into from
Jul 21, 2023

Conversation

flavio-b
Copy link
Contributor

@flavio-b flavio-b commented Jul 2, 2023

Fix typo. Webhook topic should be "customers/redact".

What this PR does

Just changes a webhook type in shopify_app.rb initializer template.

Reviewer's guide to testing

Create a brand new app using the generators. Submit a "customers/redact" webhook to the app.

Fix typo. Webhook topic should be "customers/redact".
@flavio-b flavio-b changed the title Update shopify_app.rb.tt Fix typo in customers/redact webhook topic Jul 2, 2023
Copy link
Contributor

@nelsonwittwer nelsonwittwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@nelsonwittwer nelsonwittwer merged commit 73b2863 into Shopify:main Jul 21, 2023
7 checks passed
@flavio-b flavio-b deleted the patch-1 branch July 21, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants