Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete session with repository #1773

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Delete session with repository #1773

merged 2 commits into from
Jan 22, 2024

Conversation

lizkenyon
Copy link
Contributor

@lizkenyon lizkenyon commented Jan 9, 2024 •
edited

What this PR does

Closes #1723

Reviewer's guide to testing

  • Are sessions still deleted as expected?

Things to focus on

  1. Are sessions still deleted as expected
  2. Do the new tests assert appropriately?

Checklist

Before submitting the PR, please consider if any of the following are needed:

  • Update CHANGELOG.md if the changes would impact users
  • Update README.md, if appropriate.
  • Update any relevant pages in /docs, if necessary
  • For security fixes, the Disclosure Policy must be followed.

@lizkenyon lizkenyon requested a review from a team as a code owner January 9, 2024 22:21
@lizkenyon lizkenyon force-pushed the liz/delete-session-with-repository branch from ba52c6f to 2830c82 Compare January 9, 2024 22:22
paulomarg
paulomarg reviewed Jan 10, 2024
View reviewed changes
Copy link
Contributor

@paulomarg paulomarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'd check a couple of things:

  • are there other places that might have directly deleted from the models before?
  • in session_repository_test, we could also ensure that we call the final destroy_by calls (maybe as a new test?). Is that overkill?

CHANGELOG.md Outdated Show resolved Hide resolved
@lizkenyon lizkenyon force-pushed the liz/delete-session-with-repository branch from 2830c82 to 5c4cd5f Compare January 10, 2024 16:29
@lizkenyon
Delete session with repository
19497b0 
users can customize their session storage so we cant rely on models like shop
@lizkenyon lizkenyon force-pushed the liz/delete-session-with-repository branch from 5c4cd5f to 19497b0 Compare January 10, 2024 16:40
@lizkenyon lizkenyon merged commit 5dfc904 into main Jan 22, 2024
8 checks passed
@lizkenyon lizkenyon deleted the liz/delete-session-with-repository branch January 22, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulomarg paulomarg paulomarg approved these changes

@nelsonwittwer nelsonwittwer Awaiting requested review from nelsonwittwer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SessionRepository#delete_session shouldn't use actual models when destroying records
2 participants
@lizkenyon @paulomarg