Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make type param optional on webhook route #1786

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Conversation

lizkenyon
Copy link
Contributor

What this PR does

Fixes Shopify Ruby Template , APP_UNINSTALLED Webhook Delivery Failed, Can't Verify CSRF Token.

  • This makes the type param on the webhooks route optional
  • When webhooks are initiated from the CLI they are sent to the /api/webhooks address
  • Prior to this change this was causing CLI initiated webhooks to error
  • The webhook type is never read from the URL param, and always from the webhook header so we do not forsee any issues with making this param optional.

Reviewer's guide to testing

Are there any cases where you forsee this being an error?

Checklist

Before submitting the PR, please consider if any of the following are needed:

  • Update CHANGELOG.md if the changes would impact users
  • Update README.md, if appropriate.
  • Update any relevant pages in /docs, if necessary
  • For security fixes, the Disclosure Policy must be followed.

@lizkenyon lizkenyon requested a review from a team as a code owner February 5, 2024 16:27
Type param is not sent on CLI initiated webhooks

We read the type from the webhook header in all cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shopify Ruby Template , APP_UNINSTALLED Webhook Delivery Failed, Can't Verify CSRF Token.
2 participants