Always register webhooks with offline sessions #1788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulomarg
force-pushed
the
register_webhooks_with_offline_tokens
branch
from
ce87d58
to
7b83b09
Compare
nelsonwittwer
approved these changes
Feb 8, 2024
paulomarg
force-pushed
the
register_webhooks_with_offline_tokens
branch
from
7b83b09
to
e81bc92
Compare
sle-c
approved these changes
Feb 8, 2024
paulomarg
force-pushed
the
register_webhooks_with_offline_tokens
branch
from
a249323
to
60d1cf1
Compare
paulomarg
force-pushed
the
register_webhooks_with_offline_tokens
branch
from
60d1cf1
to
7cb554d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Fixes #1708
Currently, we use the session we just created in the OAuth callback to trigger webhook registration. When using online tokens, that registration might not kick in before the token has expired.
To solve that, we can register webhooks using offline tokens, which won't expire.
Reviewer's guide to testing
Before this change, that would break. Now, it should work the same way.
Things to focus on
Checklist
Before submitting the PR, please consider if any of the following are needed:
CHANGELOG.mdif the changes would impact users