Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise error when incompatible controller concerns are detected #1809

Merged
merged 5 commits into from
Mar 7, 2024
Merged

Raise error when incompatible controller concerns are detected #1809

merged 5 commits into from
Mar 7, 2024

Conversation

nelsonwittwer
Copy link
Contributor

@nelsonwittwer nelsonwittwer commented Mar 7, 2024 •
edited
Loading

What this PR does

Raise error when incompatible controller concerns are detected (login protection / ensure installed)

This behavior has been warned about in logs for 2+ years prior to this breaking change.

Checklist

Before submitting the PR, please consider if any of the following are needed:

  • Update CHANGELOG.md if the changes would impact users
  • Update README.md, if appropriate.
  • Update any relevant pages in /docs, if necessary
  • For security fixes, the Disclosure Policy must be followed.

@nelsonwittwer nelsonwittwer requested a review from a team as a code owner March 7, 2024 18:44
@nelsonwittwer nelsonwittwer merged commit 2bce51b into main Mar 7, 2024
7 checks passed
@nelsonwittwer nelsonwittwer deleted the nw/incompatible_login_check branch March 7, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulomarg paulomarg paulomarg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nelsonwittwer @paulomarg