Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to unused assets and features #1865

Merged
merged 3 commits into from
Jul 2, 2024

Conversation

brendo
Copy link
Contributor

@brendo brendo commented Jun 18, 2024

What this PR does

This PR is a cleanup to:

  1. Remove non-existent references to JS files from the Rails precompile.

     "shopify_app/post_redirect.js",
     "shopify_app/top_level.js",
     "shopify_app/enable_cookies.js",
     "shopify_app/request_storage_access.js",
     "storage_access.svg",
    
  2. Remove the storage_access.svg

  3. Remove unused translation keys for features that have been removed.

Most of this is related to old features such as cookies (#617), which was removed in #1611 (2 years ago).

Checklist

Before submitting the PR, please consider if any of the following are needed:

  • Update CHANGELOG.md if the changes would impact users
  • Update README.md, if appropriate.
  • Update any relevant pages in /docs, if necessary
  • For security fixes, the Disclosure Policy must be followed.

@brendo brendo requested a review from a team as a code owner June 18, 2024 05:15
Copy link
Contributor

@paulomarg paulomarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't find any of the files removed here, and ran the gem on an app. Everything LGTM!

Thanks for taking this on!

@matteodepalo matteodepalo merged commit 2661888 into main Jul 2, 2024
7 checks passed
@matteodepalo matteodepalo deleted the chore_remove-old-assets-from-precompile branch July 2, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants