Keep original path and params when redirecting deep links to embed #1869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirillplatonov
force-pushed
the
keep-original-deeplinks-path
branch
from
9884d4c
to
ee15ed4
Compare
kirillplatonov
force-pushed
the
keep-original-deeplinks-path
branch
from
ee15ed4
to
406e315
Compare
zzooeeyy
approved these changes
Jul 2, 2024
| ShopifyApp.configuration.embedded_app = true | ||
|
|
||
| shop = "my-shop.myshopify.com" | ||
| get :redirect_to_embed, params: { shop: shop, foo: "bar" } |
There was a problem hiding this comment.
Could we add these extra params to test that it doesn't get included in the redirect?
Suggested change
| get :redirect_to_embed, params: { shop: shop, foo: "bar" } | |
| get :redirect_to_embed, params: { shop: shop, foo: "bar", host: "host", id_token:"id_token" } |
kirillplatonov
force-pushed
the
keep-original-deeplinks-path
branch
from
af7b0c4
to
c70c32c
Compare
matteodepalo
approved these changes
Jul 3, 2024
|
@matteodepalo resolved changelog conflict. Ready for merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Fixes deep link behavior to make sure the original path and params are preserved after redirect to app embed. Right now all deep links are redirected to home page. In addition to deep links it fixes opening links in new tab in app embed.
CleanShot.2024-06-23.at.22.38.32.mp4
Checklist
Before submitting the PR, please consider if any of the following are needed:
CHANGELOG.mdif the changes would impact usersREADME.md, if appropriate./docs, if necessary