Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Rails version to create_shops generator template #423

Merged
merged 1 commit into from
Jun 15, 2017

Conversation

AWaselnuk
Copy link
Contributor

Closes #415

Rails 5 requires the Rails version in the migration parent class apparently. This PR adds that via an erb template. It has to be in a minor version format [x.x]

Do I need to bump a version number somewhere?

@AWaselnuk AWaselnuk force-pushed the fix-shop-migration-generator branch from 84bb928 to 9088812 Compare June 15, 2017 19:51
@AWaselnuk AWaselnuk merged commit 97a6110 into master Jun 15, 2017
@amorimlucas
Copy link

amorimlucas commented Jun 16, 2017

I'm having this exact issue. Now I'm trying to add gem 'shopify_app', '~> 7.2.10' to my Gemfile (with the new version), but I get the error:

Could not find gem 'shopify_app (~> 7.2.10)' in any of the gem sources listed in your Gemfile.

@kevinhughes27
Copy link
Contributor

kevinhughes27 commented Jun 16, 2017 via email

@amorimlucas
Copy link

I'm using this:

gem 'shopify_app', '7.2.10', :git => 'https://github.com/Shopify/shopify_app'

And it looks like it installed correctly. But I'm still getting the original error:

Directly inheriting from ActiveRecord::Migration is not supported.

@kevinhughes27
Copy link
Contributor

kevinhughes27 commented Jun 16, 2017 via email

@amorimlucas
Copy link

amorimlucas commented Jun 16, 2017

I tried it with a fresh rails app and it worked.

@kevinhughes27
Copy link
Contributor

Are you using github master in your gemfile? This worked for me last Friday with rails 5.1. We'll try and cut a release today.

@amorimlucas
Copy link

Yes, using the github master got it to work for me.

Another question: Do you guys know how to load your embedded app using localhost:3000 for your URLs? I tried using a self-signed SSL, but it didn't work.

@kevinhughes27
Copy link
Contributor

I use ngrok or forwardhq which has ssl

@jamiemtdwyer
Copy link
Contributor

jamiemtdwyer commented Jun 23, 2017

I'm a massive fan of ngrok

I know others have successfully gotten self-signed SSL certs to work but I find it's not worth the hassle.

@amorimlucas
Copy link

Got it to work with ngrok, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants