-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Rails version to create_shops generator template #423
Conversation
84bb928
to
9088812
Compare
I'm having this exact issue. Now I'm trying to add
|
We haven't cut a release yet. You can point your gemfile to github for the
time being.
…On Jun 16, 2017 4:05 PM, "amorimlucas" ***@***.***> wrote:
I'm having this exact issue. I'm trying to add gem 'shopify_app', '>
7.2.10' to my Gemfile (with the new version), but I get the error "Could
not find gem 'shopify_app (> 7.2.10)' in any of the gem sources listed in
your Gemfile."
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#423 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AB39sQgpo4CHOocb2Pi9Xy8EgSgu0MS3ks5sEuABgaJpZM4N7pQW>
.
|
I'm using this:
And it looks like it installed correctly. But I'm still getting the original error:
|
Try master aka remove the version
…On Jun 16, 2017 4:25 PM, "amorimlucas" ***@***.***> wrote:
I'm using this:
gem 'shopify_app', '7.2.10', :git => 'https://github.com/Shopify/
shopify_app'
And it looks like it installed correctly. But I'm still getting the
original error:
Directly inheriting from ActiveRecord::Migration is not supported.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#423 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AB39sb06d5JakxhhpZDsFcurkT6a_91Cks5sEuSvgaJpZM4N7pQW>
.
|
I tried it with a fresh rails app and it worked. |
Are you using github master in your gemfile? This worked for me last Friday with rails 5.1. We'll try and cut a release today. |
Yes, using the github master got it to work for me. Another question: Do you guys know how to load your embedded app using localhost:3000 for your URLs? I tried using a self-signed SSL, but it didn't work. |
I use ngrok or forwardhq which has ssl |
I'm a massive fan of ngrok I know others have successfully gotten self-signed SSL certs to work but I find it's not worth the hassle. |
Got it to work with ngrok, thanks! |
Closes #415
Rails 5 requires the Rails version in the migration parent class apparently. This PR adds that via an erb template. It has to be in a minor version format
[x.x]
Do I need to bump a version number somewhere?