Allow specifying namespace for webhooks jobs #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinhughes27
approved these changes
Aug 31, 2017
kdonovan
force-pushed
the
namespace_webhook_jobs
branch
from
1b4b40d
to
1679842
Compare
|
Yep! Updated the readme and added a CHANGELOG line as well. |
|
Actually, please hold on the merge on this -- I'm exploring a tweak. I'll comment again when it's good to go. |
kdonovan
force-pushed
the
namespace_webhook_jobs
branch
from
1679842
to
32b93f8
Compare
|
OK - this is good to go now. In order to support plural namespaces (e.g. |
|
Can you add a test? |
kdonovan
force-pushed
the
namespace_webhook_jobs
branch
from
32b93f8
to
548e007
Compare
|
Yep! Tests added. |
|
Awesome thanks ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tweak allow specifying a namespace for the webhook jobs.
Rationale: I'm trying to build a generic ecommerce app, keeping in mind that I may expand to support non-Shopify stores in the future. With that in mind, I've namespaced my ShopifyApp webhook jobs under
jobs/shopify/xxx_job.rb, but despite mounting ShopifyApp under '/shopify', the webhook controller was always raising ShopifyApp::MissingWebhookJobError because it was hardcoded to assume the webhook job names were in the top-level namespace.