Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial configuration for translation platform #623

Merged
merged 1 commit into from
Sep 10, 2018

Conversation

translation-platform
Copy link
Contributor

Owners:

Welcome to Shopify Translation Platform

This PR contains the configuration files required to have your source (English) strings sent for translation, and receive translations back into your repository.

Please review this PR before merging it!

  • Review the configuration to familiarize yourself with the configuration options available.
  • Make sure the specified components in translation.yml cover all your source files.
  • Make sure the name of the component represents the audience of your project:
    • buyer for end users of Shopify stores
    • merchant where the users are merchants
    • partner for Shopify partners

Questions about this PR? Hop in the #intl-services Slack channel. We're happy to help!

@Shopify/translation-platform

@francinen francinen requested a review from ragalie August 23, 2018 17:00
@francinen
Copy link
Contributor

#617 introduces new English strings to the PR which should be translated into other supported locales.

@translation-platform
Copy link
Contributor Author

🕐 This pull request has been open for some time now 🕐

It is important to merge it as soon as possible in order to avoid dealing with merge conflicts.

More importantly the content in here really wants to reach production so everyone can benefit from it.

💚

2 similar comments
@translation-platform
Copy link
Contributor Author

🕐 This pull request has been open for some time now 🕐

It is important to merge it as soon as possible in order to avoid dealing with merge conflicts.

More importantly the content in here really wants to reach production so everyone can benefit from it.

💚

@translation-platform
Copy link
Contributor Author

🕐 This pull request has been open for some time now 🕐

It is important to merge it as soon as possible in order to avoid dealing with merge conflicts.

More importantly the content in here really wants to reach production so everyone can benefit from it.

💚

@translation-platform
Copy link
Contributor Author

🕐 This pull request has been open for some time now 🕐

It is important to merge it as soon as possible in order to avoid dealing with merge conflicts.

More importantly the content in here really wants to reach production so everyone can benefit from it.

💚

1 similar comment
@translation-platform
Copy link
Contributor Author

🕐 This pull request has been open for some time now 🕐

It is important to merge it as soon as possible in order to avoid dealing with merge conflicts.

More importantly the content in here really wants to reach production so everyone can benefit from it.

💚

translation.yml Outdated
source_language: en
target_languages: [de, es, fr, it, ja]
components:
- name: 'partner'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like the users are merchants, since all of the strings are merchant-facing.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restored the initial state of this file 👍

@translation-platform
Copy link
Contributor Author

🕐 This pull request has been open for some time now 🕐

It is important to merge it as soon as possible in order to avoid dealing with merge conflicts.

More importantly the content in here really wants to reach production so everyone can benefit from it.

💚

@francinen francinen force-pushed the translation-platform/initial-configuration branch from 80f985a to 9e4c9c3 Compare September 6, 2018 13:44
Copy link
Contributor

@tylerball tylerball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@translation-platform
Copy link
Contributor Author

🕐 This pull request has been open for some time now 🕐

It is important to merge it as soon as possible in order to avoid dealing with merge conflicts.

More importantly the content in here really wants to reach production so everyone can benefit from it.

💚

1 similar comment
@translation-platform
Copy link
Contributor Author

🕐 This pull request has been open for some time now 🕐

It is important to merge it as soon as possible in order to avoid dealing with merge conflicts.

More importantly the content in here really wants to reach production so everyone can benefit from it.

💚

@francinen francinen force-pushed the translation-platform/initial-configuration branch from 9e4c9c3 to 39015dc Compare September 10, 2018 13:06
@francinen francinen merged commit 4c1ccba into master Sep 10, 2018
@francinen francinen deleted the translation-platform/initial-configuration branch September 10, 2018 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants