Update api version handling #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanema
approved these changes
Sep 6, 2019
| @@ -10,3 +10,6 @@ | |||
| config.api_version = "<%= @api_version %>" | |||
| config.session_repository = ShopifyApp::InMemorySessionStore | |||
| end | |||
|
|
|||
| # ShopifyApp::Utils.fetch_known_api_versions # Uncomment to fetch known api versions from shopify servers on boot | |||
| # ShopifyAPI::ApiVersion.version_lookup_mode = :raise_on_unknown # Uncomment to raise an error if attempting to use an api version that was not previously known | |||
alexaitken
reviewed
Sep 6, 2019
jtgrenz
force-pushed
the
update-api-version-handling
branch
from
f58974c
to
35841d9
Compare
jtgrenz
force-pushed
the
update-api-version-handling
branch
from
35841d9
to
d370f0a
Compare
jtgrenz
force-pushed
the
update-api-version-handling
branch
from
d370f0a
to
db630cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the install generator to use the new api_version from v8.0.0 of shopify_api
I debated adding adding config flags for the generator to set the api_version lookup mode and the fetch_known_version on boot, but it doesn't strike me as something you'd want to necessarily configure via a flag. I opted to just add it to the initializer and comment it out in case anyone wants to enable it.
I wrapped
ShopifyAPI::ApiVersion.fetch_known_versionsin a utility method that just logs out that its fetching the versions and rescues and logs that the versions could not be fetched if it hits anActiveResource::ConnectionError