Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds config host for ngrok url #802

Merged
merged 1 commit into from
Oct 16, 2019
Merged

adds config host for ngrok url #802

merged 1 commit into from
Oct 16, 2019

Conversation

katiedavis
Copy link
Contributor

@katiedavis katiedavis requested a review from a team as a code owner October 15, 2019 17:55
tanema
tanema reviewed Oct 15, 2019
View reviewed changes
lib/generators/shopify_app/install/install_generator.rb
def insert_hosts_into_development_config
inject_into_file(
'config/environments/development.rb',
" config.hosts << /\\h+.ngrok.io/\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can insert a regex into hosts? I did not know this!

tanema
tanema reviewed Oct 15, 2019
View reviewed changes
Copy link
Contributor

@tanema tanema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although the regex is a cool feature, I think we should put in something like ENV['APP_HOST'] so that we can specify it with the .env file and so that when they deploy they can just change their env file.

@katiedavis
Copy link
Contributor Author

Although the regex is a cool feature, I think we should put in something like ENV['APP_HOST'] so that we can specify it with the .env file and so that when they deploy they can just change their env file.

After discussion with @tanema we've decided to keep the regex because not all users will have a host listed in their env file and this config is only used in development.

@katiedavis katiedavis merged commit 07df4c0 into master Oct 16, 2019
@katiedavis katiedavis deleted the config-host branch October 16, 2019 15:48
@katiedavis katiedavis temporarily deployed to rubygems October 16, 2019 17:23 Inactive
@tjoyal tjoyal mentioned this pull request Oct 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerball tylerball tylerball approved these changes

@tanema tanema tanema approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@katiedavis @tylerball @tanema