Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump browser_sniffer to 1.1.3 #824

Merged
merged 1 commit into from
Nov 20, 2019
Merged

bump browser_sniffer to 1.1.3 #824

merged 1 commit into from
Nov 20, 2019

Conversation

RyanBillard
Copy link

This bumps the browser_sniffer gem to 1.1.3, which included changes to support a new format of user agent strings in POS Next.

I also bumped the version.rb so that dependent apps can pull in this change.

@ghost ghost added the cla-needed label Nov 19, 2019
@RyanBillard RyanBillard marked this pull request as ready for review November 19, 2019 20:35
@RyanBillard RyanBillard requested a review from a team as a code owner November 19, 2019 20:35
@RyanBillard
Copy link
Author

I signed the CLA...and I also work at Shopify. Not sure why the check is still failing.

@ghost ghost added the cla-needed label Nov 20, 2019
@gfscott
Copy link
Contributor

gfscott commented Nov 20, 2019

Hey @RyanBillard, I don't know why the CLA bot isn't working. I approved, do you have the ability to merge, or do you want me to do it?

@RyanBillard
Copy link
Author

The merge button is disabled for me, I'd appreciate if you could merge please 😄

@gfscott gfscott merged commit 397a376 into master Nov 20, 2019
@tylerball tylerball temporarily deployed to rubygems November 21, 2019 18:50 Inactive
@tanema tanema deleted the browser-sniffer-1.1.3 branch January 21, 2020 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants