Skip to content
This repository has been archived by the owner on Apr 27, 2021. It is now read-only.

Provide callback for when assets complete or if upload times out for some reason #154

Closed
mpiotrowicz opened this issue May 12, 2015 · 9 comments

Comments

@mpiotrowicz
Copy link

cc @cshold @stevebosworth anything else required?

@cshold
Copy link
Contributor

cshold commented May 13, 2015

I'd just make sure all assets are done uploading as multiple can be changed/saved/created at a time. A callback after theme replace would be nice too.

@csaunders
Copy link
Contributor

Shopify/themekit#51

@mpiotrowicz
Copy link
Author

we're currently still using the theme gem, any hope of updating it here?

@csaunders
Copy link
Contributor

Now that shopify owns themekit, is still still a concern?

@mpiotrowicz
Copy link
Author

@cshold @stevebosworth

@stevebosworth
Copy link

If we're committed to actively working on themekit and sunsetting the gem, I'm fine with leaving this as is. if that's still a ways off it would be great to get this available in the gem.

@csaunders
Copy link
Contributor

Let's get a milestone rolling on themekit and start adding the missing
features that are blocking you from using it for realz.

On Tue, Sep 1, 2015 at 3:41 PM, Steve Bosworth notifications@github.com
wrote:

If we're committed to actively working on themekit and sunsetting the gem,
I'm fine with leaving this as is. if that's still a ways off it would be
great to get this available in the gem.


Reply to this email directly or view it on GitHub
#154 (comment)
.

Chris Saunders // Developer @ Shopify

@csaunders
Copy link
Contributor

Here's our milestone.

Anything else you can think of?

Should administrative things go in there as well (updating documentation, etc)?

/cc @fredryk

@cshold
Copy link
Contributor

cshold commented Sep 3, 2015

👍 can be closed in favour of going ahead on themekit.

@ghost ghost unassigned csaunders May 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants