Separate parsing and indexing

Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Shopify · Mar 6, 2024 · 9c9aed2 · 9c9aed2
1 parent 2b12014
commit 9c9aed2
Showing 1 changed file with 23 additions and 5 deletions.
diff --git a/lib/spoom/deadcode.rb b/lib/spoom/deadcode.rb
@@ -36,17 +36,35 @@ class IndexerError < Error; end
     class << self
       extend T::Sig
 
-      sig { params(index: Index, ruby: String, file: String, plugins: T::Array[Deadcode::Plugins::Base]).void }
-      def index_ruby(index, ruby, file:, plugins: [])
-        node = SyntaxTree.parse(ruby)
-        visitor = Spoom::Deadcode::Indexer.new(file, ruby, index, plugins: plugins)
-        visitor.visit(node)
+      sig { params(ruby: String, file: String).returns(SyntaxTree::Node) }
+      def parse_ruby(ruby, file:)
+        SyntaxTree.parse(ruby)
       rescue SyntaxTree::Parser::ParseError => e
         raise ParserError.new("Error while parsing #{file} (#{e.message} at #{e.lineno}:#{e.column})", parent: e)
+      end
+
+      sig do
+        params(
+          index: Index,
+          node: SyntaxTree::Node,
+          ruby: String,
+          file: String,
+          plugins: T::Array[Deadcode::Plugins::Base],
+        ).void
+      end
+      def index_node(index, node, ruby, file:, plugins: [])
+        visitor = Spoom::Deadcode::Indexer.new(file, ruby, index, plugins: plugins)
+        visitor.visit(node)
       rescue => e
         raise IndexerError.new("Error while indexing #{file} (#{e.message})", parent: e)
       end
 
+      sig { params(index: Index, ruby: String, file: String, plugins: T::Array[Deadcode::Plugins::Base]).void }
+      def index_ruby(index, ruby, file:, plugins: [])
+        node = parse_ruby(ruby, file: file)
+        index_node(index, node, ruby, file: file, plugins: plugins)
+      end
+
       sig { params(index: Index, erb: String, file: String, plugins: T::Array[Deadcode::Plugins::Base]).void }
       def index_erb(index, erb, file:, plugins: [])
         ruby = ERB.new(erb).src