Make dead code indexing use a Model to index classes
#562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 19, 2024
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Morriar
force-pushed
the
at-model-deadcode-classes
branch
from
6359779
to
49c816f
Compare
KaanOzkan
approved these changes
Jun 20, 2024
| # end | ||
| # end | ||
| # ~~~ | ||
| sig { params(indexer: Indexer, definition: Definition).void } | ||
| def on_define_class(indexer, definition) | ||
| sig { params(symbol_def: Model::Class, definition: Definition).void } |
There was a problem hiding this comment.
Should this be abstract?
There was a problem hiding this comment.
We don't want to crash when calling on_define_class to a plugin that do nothing with it, we just want it to no-op.
We _could_refactor this to have multiple interfaces:
module ClassPlugin
interface!
sig { abstract.void }
def on_define_class; endand then let the plugins cherry pick the interfaces they want to implement.
But in practice I just rely on YJIT to optimize this empty calls away.
egiurleo
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first PR on a sequence moving the dead code analysis use the
Modelintroduced in #557 rather than its custom indexer.In this PR we migrate the indexing of classes:
Deadcode::Indextake aModel(bc18520)Deadcode::Indexer(9433fda)Deadcode::PluginstakeModel::SymbolDefwhen callingon_define_class(6359779)There is no behavior change: no tests are changed.
This PR is easier to review commit by commit.