Make dead code indexing use a Model
to index constants
#564
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #563.
This time, we switch the indexing of constants to Model:
on_define_constant
(7894f64)There is a slight behavior change, before we were able to look at the nesting context when defining
T::Enum
constants. So with this code:We could tell that
CONST
wasn't defined inside aenums do ... end
block and thus ignoreCONST
within thesorbet
plugin.To avoid carrying the
enums do ... end
information and putting pressure on the GC, I dropped this feature, soCONST
will be marked asignored
.In practice this case doesn't happen much, this is a regression that I deemed acceptable.
This PR is easier to review commit by commit.