Catch error conditions that can result even when using UDP #6

Merged
merged 1 commit into from Feb 10, 2012

Projects

None yet

2 participants

@betamatt
Contributor

There's a bunch of issues that can result from the DNS request which happens before packets start going out over UDP. This patch ensures that any such network errors are logged instead of bubbling up and that requests which black-hole will timeout quickly.

Contributor

Scary to think that StatsD could block the request. Nice fix. And +1 on your usage of #fetch for a default value :)

@jstorimer jstorimer merged commit 171c0de into Shopify:master Feb 10, 2012
Contributor

Thanks. If you don't have anything else in the pipe, mind cutting a point release?

Contributor

Done. v1.1.2 is available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment