Catch error conditions that can result even when using UDP #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Scary to think that StatsD could block the request. Nice fix. And +1 on your usage of #fetch for a default value :) |
jstorimer
added a commit
that referenced
this pull request
Feb 10, 2012
Catch error conditions that can result even when using UDP
|
Thanks. If you don't have anything else in the pipe, mind cutting a point release? |
|
Done. v1.1.2 is available. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a bunch of issues that can result from the DNS request which happens before packets start going out over UDP. This patch ensures that any such network errors are logged instead of bubbling up and that requests which black-hole will timeout quickly.