fix role_name return type

Shopify · Nov 12, 2022 · 216f6e6 · 216f6e6
1 parent 49aa92f
commit 216f6e6
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/lib/tapioca/dsl/compilers/active_record_delegated_types.rb b/lib/tapioca/dsl/compilers/active_record_delegated_types.rb
@@ -43,7 +43,7 @@ module Compilers
       #     sig { returns(Class) }
       #     def entryable_class; end
       #
-      #     sig { returns(String) }
+      #     sig { returns(ActiveSupport::StringInquirer) }
       #     def entryable_name; end
       #
       #     sig { returns(T::Boolean) }
@@ -107,7 +107,7 @@ def populate_role_accessors(mod, role, types)
           mod.create_method(
             "#{role}_name",
             parameters: [],
-            return_type: "String",
+            return_type: "ActiveSupport::StringInquirer",
           )
 
           mod.create_method(

diff --git a/manual/compiler_activerecorddelegatedtypes.md b/manual/compiler_activerecorddelegatedtypes.md
@@ -30,7 +30,7 @@ class Entry
     sig { returns(Class) }
     def entryable_class; end
 
-    sig { returns(String) }
+    sig { returns(ActiveSupport::StringInquirer) }
     def entryable_name; end
 
     sig { returns(T::Boolean) }

diff --git a/spec/tapioca/dsl/compilers/active_record_delegated_types_spec.rb b/spec/tapioca/dsl/compilers/active_record_delegated_types_spec.rb
@@ -127,7 +127,7 @@ def comment_id; end
                         sig { returns(Class) }
                         def entryable_class; end
 
-                        sig { returns(String) }
+                        sig { returns(ActiveSupport::StringInquirer) }
                         def entryable_name; end
 
                         sig { returns(T.nilable(Message)) }
@@ -195,7 +195,7 @@ def comment_uuid; end
                         sig { returns(Class) }
                         def entryable_class; end
 
-                        sig { returns(String) }
+                        sig { returns(ActiveSupport::StringInquirer) }
                         def entryable_name; end
 
                         sig { returns(T.nilable(Message)) }