Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tapioca dsl rejects valid values from --exclude if they are not loaded #1786

Closed
aalong-tr opened this issue Feb 5, 2024 · 2 comments · Fixed by #1794
Closed

tapioca dsl rejects valid values from --exclude if they are not loaded #1786

aalong-tr opened this issue Feb 5, 2024 · 2 comments · Fixed by #1794
Assignees
Labels
bug Something isn't working good-first-issue Good for newcomers

Comments

@aalong-tr
Copy link

I use some automation scripts to simplify managing Sorbet across modules in a monorepo.
One of these scripts uses the command tapioca dsl --exclude ActiveRecordFixtures UrlHelpers

As of 0.12.0, this command still works fine for the modules that load Rails in its entirety; but on a few simpler gems, the command now fails with:

Error: Cannot find compiler 'ActiveRecordFixtures'
Error: Cannot find compiler 'UrlHelpers'

Since tapioca dsl --list-compilers does not list these entries when run against the impacted gems, modifying my script to check for the available compilers was easy enough; but it would be nice if the --exclude flag would accept allowable compilers even when they are not loaded.

@aalong-tr aalong-tr changed the title tapioca dsl rejects valid values from --excluded if they are not loaded tapioca dsl rejects valid values from --exclude if they are not loaded Feb 6, 2024
@KaanOzkan KaanOzkan added the bug Something isn't working label Feb 6, 2024
@KaanOzkan
Copy link
Contributor

I think making them warnings instead is a good solution.

@aalong-tr
Copy link
Author

Thank you for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good-first-issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants