Make unprocessable compilers a warning instead of an error #1794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the we change if the compilers are loaded depending on if various constants are defined, running the same `tapioca dsl` command in different contexts could end up loading a different set of compilers. However, this creates a problem if users are passing in `--only` or `--exclude` for compilers with a predetermined set of compiler names, since the set of compiler names could change between runs. It is better to show a warning that the requested compilers are not available, and continue with the rest of the DSL generation process, rather than erroring out.
egiurleo
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #1786
Implementation
Since we change if the compilers are loaded depending on if various constants are defined, running the same
tapioca dslcommand in different contexts could end up loading a different set of compilers. However, this creates a problem if users are passing in--onlyor--excludefor compilers with a predetermined set of compiler names, since the set of compiler names could change between runs.It is better to show a warning that the requested compilers are not available, and continue with the rest of the DSL generation process, rather than erroring out.
Tests
Updates existing tests