Add enum column support to ActiveRecordColumns
#1000
Conversation
Handle and specify String type so it does not fall back to untyped.
| @@ -225,6 +225,8 @@ def title?; end | |||
| t.datetime :datetime_column | |||
| t.decimal :money_column | |||
| t.text :serialized_column | |||
| # Ideally this would test t.enum but that is not supported by sqlite | |||
| t.string :enum_column | |||
There was a problem hiding this comment.
This is not a valid database column given the example below. The test model constructs a default enum which maps to integer fields, so the backing column should be integer as well. Otherwise, the enum column would not work properly.
There was a problem hiding this comment.
Good catch. I updated this to test both integer and string backing columns and adjusted the associated model setup.
ghost
added
the
|
Thanks for the reviews! CLA should be coming through in the next day or two. |
|
CLA should now be signed. I don't see a way for me to trigger the check to re-run other than pushing a change to verify, but I will keep an eye out in case there is some issue. Thanks for the great contribution experience. Reviewing and providing good feedback on community PRs is a big commitment from your side and I really appreciate it. |
|
👋 Hi @q3aiml, You can try: To push again without edit. |
Allow Symbol and Integer as appropriate based on underlying column. Fix associated spec to test both integer and string columns and use proper associated enum setup.
q3aiml
force-pushed
the
type-active-record-enum-columns
branch
from
c397367
to
38cf4b0
Compare
|
|
||
| sig { params(column_type: ActiveRecord::Enum::EnumType).returns(String) } | ||
| def enum_setter_type(column_type) | ||
| case column_type.subtype |
There was a problem hiding this comment.
This breaks rails < 7 because subtype was previously private. Rails commit: rails/rails@70259f5#diff-a0de22dc0114613fdc67f48c916e70b9983ef47bcc84b96232c36398af1d166fR156-R159
Motivation
Handle enum columns so they do not fall back to untyped. Primarily I want this so that the type includes
T.nilablewhen appropriate which does not happen when it is untyped.Implementation
I added support for
ActiveRecord::Enum::EnumTypeinActiveRecordColumnTypeHelper. The setter method's type supports all coercible types. This requires inspecting the underlying column type to differentiate between numeric and non-numeric backing columns.Tests
Added coverage in existing test for generating proper types for every ActiveRecord column type.