Dsl::Compilers::ActiveRecordRelations: fix #find_sole_by, #sole #1007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
KaanOzkan
approved these changes
Jun 21, 2022
paracycle
approved these changes
Jun 27, 2022
|
Thanks so much! 😊 |
paracycle
added a commit
that referenced
this pull request
Jul 1, 2022
Dsl::Compilers::ActiveRecordRelations: fix #find_sole_by, #sole
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The specs introduced for
soleandfind_sole_byin 5f90df1 are not quite right.See https://github.com/kivikakk/rails/blob/9e1cdf27ebaff31005f3d2bf02d97dfb116a3707/activerecord/lib/active_record/relation/finder_methods.rb#L107-L131.
Implementation
Added logic for each of these to generated the correct signatures.
Tests
Tests adjusted.