Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a meaningful help for HTTP errors when fetching annotations #1008

Merged
merged 1 commit into from
Jun 22, 2022

Conversation

Morriar
Copy link
Collaborator

@Morriar Morriar commented Jun 21, 2022

Motivation

Provide some guidance on how to solve HTTP errors when fetching annotations from a private repository:

$ bundle exec tapioca annotations --sources https://private-repo

Will display this:
image

Tests

See automated tests.

Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
@Morriar Morriar added the enhancement New feature or request label Jun 21, 2022
@Morriar Morriar requested a review from a team June 21, 2022 14:56
@Morriar Morriar self-assigned this Jun 21, 2022
Copy link
Contributor

@adisonlampert adisonlampert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! ⭐

lib/tapioca/commands/annotations.rb Show resolved Hide resolved
@Morriar Morriar merged commit 1506430 into main Jun 22, 2022
@Morriar Morriar deleted the at-netrc-error branch June 22, 2022 18:13
@shopify-shipit shopify-shipit bot temporarily deployed to production July 7, 2022 17:53 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants