Use default gemfile path instead of Rails root when listing engines #1018
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
For projects that aren't Rails, such as Tapioca itself,
Rails.root
isnil
, which then breaks when trying to invokeRails.root.to_path
.Implementation
Add a check for verifying that
Rails.root
is set before continuing down to list engines. This enables Tapioca to generate RBIs for itself again.Tests
I couldn't figure out a way of forcing
Rails.root
to returnnil
. Let me know if you have ideas.