Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tapioca init behave like srb init #1026

Merged
merged 6 commits into from
Jul 7, 2022
Merged

Make tapioca init behave like srb init #1026

merged 6 commits into from
Jul 7, 2022

Conversation

Morriar
Copy link
Collaborator

@Morriar Morriar commented Jun 30, 2022

Motivation

Initializing a project with Tapioca is basically a succession of 4 commands:

$ tapioca init
$ tapioca annotations
$ tapioca gems
$ tapioca todo

This PR does two things:

  1. it renames the current tapioca init command into tapioca configure
  2. it makes tapioca init run the configure, annotations, gems and todo commands all in one

This brings us closer from the srb init experience.

I didn't add tapioca dsl in the mix has over the few projects I tried the new tapioca init command, all crashed when trying to generate the DSLs.

@Morriar Morriar added enhancement New feature or request breaking-change Non-backward compatible change labels Jun 30, 2022
@Morriar Morriar requested a review from a team June 30, 2022 22:52
@Morriar Morriar self-assigned this Jun 30, 2022
lib/tapioca/cli.rb Outdated Show resolved Hide resolved
lib/tapioca/cli.rb Show resolved Hide resolved
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
lib/tapioca/cli.rb Outdated Show resolved Hide resolved
lib/tapioca/cli.rb Show resolved Hide resolved
lib/tapioca/cli.rb Outdated Show resolved Hide resolved
lib/tapioca/cli.rb Outdated Show resolved Hide resolved
lib/tapioca/cli.rb Outdated Show resolved Hide resolved
lib/tapioca/cli.rb Outdated Show resolved Hide resolved
lib/tapioca/cli.rb Outdated Show resolved Hide resolved
lib/tapioca/cli.rb Outdated Show resolved Hide resolved
lib/tapioca/cli.rb Outdated Show resolved Hide resolved
lib/tapioca/cli.rb Outdated Show resolved Hide resolved
lib/tapioca/cli.rb Outdated Show resolved Hide resolved
lib/tapioca/cli.rb Outdated Show resolved Hide resolved
lib/tapioca/cli.rb Outdated Show resolved Hide resolved
lib/tapioca/cli.rb Outdated Show resolved Hide resolved
lib/tapioca/cli.rb Outdated Show resolved Hide resolved
lib/tapioca/cli.rb Outdated Show resolved Hide resolved
lib/tapioca/cli.rb Show resolved Hide resolved
@egiurleo egiurleo force-pushed the at-tapioca-init branch 2 times, most recently from f81ab47 to 4f1a1a7 Compare July 6, 2022 21:32
lib/tapioca/cli.rb Show resolved Hide resolved
lib/tapioca/cli.rb Show resolved Hide resolved
lib/tapioca/cli.rb Outdated Show resolved Hide resolved
lib/tapioca/cli.rb Outdated Show resolved Hide resolved
lib/tapioca/cli.rb Outdated Show resolved Hide resolved
lib/tapioca/cli.rb Outdated Show resolved Hide resolved
lib/tapioca/cli.rb Outdated Show resolved Hide resolved
Copy link
Collaborator Author

@Morriar Morriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks @egiurleo for pushing this through the finish line! 🎉

@Morriar Morriar merged commit 4e4ddbf into main Jul 7, 2022
@Morriar Morriar deleted the at-tapioca-init branch July 7, 2022 16:15
@shopify-shipit shopify-shipit bot temporarily deployed to production July 7, 2022 17:53 Inactive
@shopify-shipit shopify-shipit bot temporarily deployed to 0-9-stable August 19, 2022 20:37 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Non-backward compatible change enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants