-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make tapioca init
behave like srb init
#1026
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Morriar
added
enhancement
New feature or request
breaking-change
Non-backward compatible change
labels
Jun 30, 2022
Morriar
commented
Jun 30, 2022
rafaelfranca
reviewed
Jul 1, 2022
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
vinistock
reviewed
Jul 5, 2022
egiurleo
reviewed
Jul 6, 2022
Morriar
commented
Jul 6, 2022
Morriar
commented
Jul 6, 2022
paracycle
reviewed
Jul 6, 2022
egiurleo
force-pushed
the
at-tapioca-init
branch
2 times, most recently
from
July 6, 2022 21:32
f81ab47
to
4f1a1a7
Compare
egiurleo
reviewed
Jul 6, 2022
paracycle
approved these changes
Jul 6, 2022
Morriar
commented
Jul 6, 2022
vinistock
approved these changes
Jul 7, 2022
st0012
approved these changes
Jul 7, 2022
Morriar
commented
Jul 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing, thanks @egiurleo for pushing this through the finish line! 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Initializing a project with Tapioca is basically a succession of 4 commands:
This PR does two things:
tapioca init
command intotapioca configure
tapioca init
run theconfigure
,annotations
,gems
andtodo
commands all in oneThis brings us closer from the
srb init
experience.I didn't add
tapioca dsl
in the mix has over the few projects I tried the newtapioca init
command, all crashed when trying to generate the DSLs.