Do not mark constants as seen before generating RBI for them #1040
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix foreign constants mixin for already seen ancestors
Consider the following example when running
tapioca gem gemB
:While visiting the constants of
GemB
we would:Baz
Bar
Bar
as seenBar
since it belongs toGemA
Bar
for the prependBar
because previously marked as seenImplementation
Only mark a constant as seen if we generate something for it.
Tests
See included test.