Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not index files typed: ignore when running check-shims #1054

Merged
merged 1 commit into from
Jul 12, 2022

Conversation

Morriar
Copy link
Collaborator

@Morriar Morriar commented Jul 12, 2022

Motivation

Closes #1053.

Tests

See automated tests.

Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
@Morriar Morriar added bug Something isn't working bugfix labels Jul 12, 2022
@Morriar Morriar requested a review from a team July 12, 2022 16:32
@Morriar Morriar self-assigned this Jul 12, 2022
@Morriar Morriar merged commit d9f58d3 into main Jul 12, 2022
@Morriar Morriar deleted the at-check-shims-ignore branch July 12, 2022 17:09
@shopify-shipit shopify-shipit bot temporarily deployed to production July 14, 2022 18:56 Inactive
egiurleo pushed a commit that referenced this pull request Aug 19, 2022
Do not index files typed: ignore when running `check-shims`
@shopify-shipit shopify-shipit bot temporarily deployed to 0-9-stable August 22, 2022 21:36 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

check-shims should ignore typed: ignore files
3 participants