Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix help URL for empty gem RBI files #1070

Merged
merged 2 commits into from
Jul 20, 2022
Merged

Fix help URL for empty gem RBI files #1070

merged 2 commits into from
Jul 20, 2022

Conversation

Morriar
Copy link
Collaborator

@Morriar Morriar commented Jul 20, 2022

Motivation

Currently, when producing an empty RBI file, we point the user to https://github.com/Shopify/tapioca/wiki/Manual-Gem-Requires which has been deleted:

# typed: true

# DO NOT EDIT MANUALLY
# This is an autogenerated file for types exported from the `builder` gem.
# Please instead update this file by running `bin/tapioca gem builder`.

# THIS IS AN EMPTY RBI FILE.
# see https://github.com/Shopify/tapioca/wiki/Manual-Gem-Requires

This PR changes the URL used to point to https://github.com/Shopify/tapioca#manually-requiring-parts-of-a-gem.

Tests

See automated tests.

@Morriar
Fix URL for empty RBI files
b1452ee 
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
@Morriar
Update RBIs for gems
7d31735 
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
@Morriar Morriar added the bugfix label Jul 20, 2022
@Morriar Morriar self-assigned this Jul 20, 2022
@Morriar Morriar requested a review from a team as a code owner July 20, 2022 16:47
paracycle
paracycle approved these changes Jul 20, 2022
View reviewed changes
Copy link
Member

@paracycle paracycle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@Morriar Morriar merged commit 9b356f7 into main Jul 20, 2022
@Morriar Morriar deleted the at-fix-url branch July 20, 2022 18:50
egiurleo pushed a commit that referenced this pull request Aug 19, 2022
@Morriar @egiurleo
Merge pull request #1070 from Shopify/at-fix-url
8d4a30b 
Fix help URL for empty gem RBI files
@paracycle paracycle added the backported Backported to stable branch label Aug 22, 2022
paracycle pushed a commit that referenced this pull request Aug 22, 2022
@Morriar @paracycle
Merge pull request #1070 from Shopify/at-fix-url
675bca7 
Fix help URL for empty gem RBI files
@shopify-shipit shopify-shipit bot temporarily deployed to production August 31, 2022 14:40 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paracycle paracycle paracycle approved these changes

@vinistock vinistock vinistock approved these changes

Assignees

@Morriar Morriar

Labels
backported Backported to stable branch bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Morriar @paracycle @vinistock