Don't crash on rails < 7 #1074
Merged
Don't crash on rails < 7 #1074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method `subtype` was made public in rails 7, but it did exist previously so we can use it via `send`.
paracycle
approved these changes
Jul 29, 2022
|
I don't see a failure when I run tapioca against Rails 6.1 before this patch. Is this helper being tested? |
|
Ah, found it. It is because the enum definition doesn't work in Rails 6.1, so I had to change that before seeing this failure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method
subtypewas made public in rails 7, but it did exist previously so we can use it viasend.Motivation
With rails < 7, tapioca dsl crashes with:
lib/tapioca/dsl/helpers/active_record_column_type_helper.rb:122:in 'enum_setter_type': private method 'subtype' called for #<ActiveRecord::Enum::EnumType:0x000055c8a8aefb70> (NoMethodError)Implementation
subtype was not public in rails 6, but it did exist since at least 5.0 https://github.com/rails/rails/blob/v5.0.0/activerecord/lib/active_record/enum.rb#L143
Tests
No idea how to add a test for this.