Load DSL compilers from gems #1075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
approved these changes
Jul 22, 2022
st0012
approved these changes
Jul 22, 2022
paracycle
force-pushed
the
uk-load-compilers-from-gems
branch
from
3dd038f
to
fe92fc1
Compare
Morriar
approved these changes
Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Instead of bundling all the DSL compilers inside Tapioca, we've been asking teams to write their own DSL compilers inside their gems and applications. However, until now there wasn't a good way to load those DSL compilers apart from hacky methods like requiring them from a Ruby file inside
sorbet/tapioca/compilers.Implementation
The implementation is pretty much based on how Minitest loads its plugins from other gems.
Gem.find_filesis a method that is designed to discover features from other gems, and by using that we can load all compilers defined by Ruby files insidelib/tapioca/dsl/compilersfolders. This also includes loading all of the DSL compilers that are bundled into Tapioca as well, btw, so it neatly unifies all these code paths.Tests
Add a test for loading a DSL compiler from the expected folder in a gem.