Thor: Love (❤️ ) and Thunder (⚡) #1083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thor already knows how to deal with `exit` status. If call `exit` ourselves, it become harder to reuse those commands, in say, profiling calls, because as soon the command suceeds, we were exiting the entire process, not allowing the profiler to dump the data. If we use the mechamism inside Thor to handle exits, we also can simplify the stderr output code. This also allowed us to fix some TODOs that were in the tests about the error not being sent to stderr.
Morriar
approved these changes
Jul 29, 2022
vinistock
approved these changes
Jul 29, 2022
paracycle
pushed a commit
that referenced
this pull request
Aug 22, 2022
Thor: Love (❤️ ) and Thunder (⚡)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When working in profiling the
check-shimscommand I was being surprised my profiling data wasn't be written to the disk. I found that it was because we were exiting the process from inside theCommandclass.Thor already knows how to deal with
exitstatus, so it is better to use the mechanism so we can make easier to profile out commands.Implementation
Avoid
exitcall in the command classes and instead usingThor::Errorto provide the messages to STDERR, and exit with the right status.